Enrich administrative profiles from SGU

2026-09-03 12:21:43 -06:00
parent d50a4d9895
commit 403132f869
12 changed files with 609 additions and 22 deletions
@@ -11,6 +11,12 @@ namespace SGU.AuthBroker.Tests;

 public sealed class NtlmCredentialValidatorTests
 {
+    private static readonly UserIdentity Administrative = new(
+        "AD017045",
+        "AD",
+        "017045",
+        InstitutionalRole.Administrative);
+
    private static readonly UserIdentity Student = new(
        "AL123456",
        "AL",
@@ -101,6 +107,91 @@ public sealed class NtlmCredentialValidatorTests
            handler.RequestPaths[4]);
    }

+    [Fact]
+    public async Task VerifiedAdministrativeProfileIsEnrichedFromPersonalAndLocationPages()
+    {
+        SequenceHandler handler = new(
+            Challenge(),
+            Response(HttpStatusCode.OK),
+            Response(
+                HttpStatusCode.OK,
+                """
+                <span id="ctl00_contenedor_decEncabezado_lblNombre">017045 - NOMBRE ANTERIOR</span>
+                <span id="ctl00_contenedor_decEncabezado_lblCorreo">persona@lasalle.mx</span>
+                <span id="ctl00_contenedor_decEncabezado_lblPuesto">ANALISTA</span>
+                """),
+            Response(
+                HttpStatusCode.OK,
+                """
+                <input id="ctl00_contenedor_txtNombre" value="MARÍA DEL CARMEN" />
+                <input id="ctl00_contenedor_txtApaterno" value="DE LA FUENTE" />
+                <input id="ctl00_contenedor_txtAmaterno" value="O'CONNOR" />
+                """),
+            Response(
+                HttpStatusCode.OK,
+                """
+                <input id="ctl00_contenedor_txtCalle" value="CALLE DEL SOL" />
+                <input id="ctl00_contenedor_txtNoExt" value="15" />
+                <input id="ctl00_contenedor_txtCP" value="01000" />
+                <select id="ctl00_contenedor_ddlEstado">
+                  <option selected="selected">CIUDAD DE MÉXICO</option>
+                </select>
+                <select id="ctl00_contenedor_ddlLocalidad">
+                  <option selected="selected">ÁLVARO OBREGÓN</option>
+                </select>
+                <select id="ctl00_contenedor_ddlColonia">
+                  <option>FLORIDA</option>
+                </select>
+                """));
+        NtlmCredentialValidator validator = CreateValidator(handler);
+
+        NtlmValidationResult result = await validator.ValidateAsync(
+            Administrative,
+            "test-password",
+            TestContext.Current.CancellationToken);
+
+        Assert.Equal(NtlmValidationStatus.Valid, result.Status);
+        Assert.NotNull(result.Profile);
+        Assert.Equal("017045", result.Profile.EmployeeNumber);
+        Assert.Equal("María del Carmen de la Fuente O'Connor", result.Profile.DisplayName);
+        Assert.Equal("María del Carmen", result.Profile.GivenName);
+        Assert.Equal("de la Fuente O'Connor", result.Profile.Surname);
+        Assert.Equal("persona@lasalle.mx", result.Profile.Email);
+        Assert.Equal("Analista", result.Profile.JobTitle);
+        Assert.Equal("Calle del Sol 15\r\nFlorida", result.Profile.StreetAddress);
+        Assert.Equal("Álvaro Obregón", result.Profile.City);
+        Assert.Equal("Ciudad de México", result.Profile.State);
+        Assert.Equal("01000", result.Profile.PostalCode);
+        Assert.Equal(
+            [
+                "/psulsa/",
+                "/psulsa/",
+                "/psulsa/gadmon/capitalhumano/controlincidencias/incidencias.aspx",
+                "/psulsa/gadmon/capitalhumano/datos/personales.aspx",
+                "/psulsa/gadmon/capitalhumano/datos/ubicacion.aspx"
+            ],
+            handler.RequestPaths);
+    }
+
+    [Fact]
+    public async Task AdministrativeSupplementalPagesRequireAVerifiedEmployeeNumber()
+    {
+        SequenceHandler handler = new(
+            Challenge(),
+            Response(HttpStatusCode.OK),
+            Response(HttpStatusCode.OK, "<html><body>Datos inesperados</body></html>"));
+        NtlmCredentialValidator validator = CreateValidator(handler);
+
+        NtlmValidationResult result = await validator.ValidateAsync(
+            Administrative,
+            "test-password",
+            TestContext.Current.CancellationToken);
+
+        Assert.Equal(NtlmValidationStatus.Valid, result.Status);
+        Assert.Null(result.Profile);
+        Assert.Equal(3, handler.RequestPaths.Count);
+    }
+
    private static NtlmCredentialValidator CreateValidator(SequenceHandler handler)
    {
        BrokerOptions options = new()
@@ -109,6 +200,9 @@ public sealed class NtlmCredentialValidatorTests
            {
                Endpoint = "https://sgu.example/",
                AuthenticationPath = "/psulsa/",
+                AdministrativeProfilePath = "/psulsa/gadmon/capitalhumano/controlincidencias/incidencias.aspx",
+                AdministrativePersonalProfilePath = "/psulsa/gadmon/capitalhumano/datos/personales.aspx",
+                AdministrativeLocationProfilePath = "/psulsa/gadmon/capitalhumano/datos/ubicacion.aspx",
                StudentProfilePath = "/psulsa/alumnos/consultainformacionalumnos/consultainformacion.aspx",
                AllowedRedirectHosts = ["sgu.example"],
                TimeoutSeconds = 5,
@@ -136,10 +230,12 @@ public sealed class NtlmCredentialValidatorTests
        return response;
    }

-    private static HttpResponseMessage Response(HttpStatusCode statusCode) =>
+    private static HttpResponseMessage Response(
+        HttpStatusCode statusCode,
+        string content = "<html></html>") =>
        new(statusCode)
        {
-            Content = new StringContent("<html></html>")
+            Content = new StringContent(content)
        };

    private sealed class SequenceHandler(params HttpResponseMessage[] responses) : HttpMessageHandler